CWE-763: Release of Invalid Pointer or Reference

Description

The product attempts to return a memory resource to the system, but it calls the wrong release function or calls the appropriate release function incorrectly.

This weakness can take several forms, such as:

Potential Impact

Integrity, Availability, Confidentiality

Modify Memory, DoS: Crash, Exit, or Restart, Execute Unauthorized Code or Commands

Demonstrative Examples

This code attempts to tokenize a string and place it into an array using the strsep function, which inserts a \0 byte in place of whitespace or a tab character. After finishing the loop, each string in the AP array points to a location within the input string.

Bad

char **ap, *argv[10], *inputstring;for (ap = argv; (*ap = strsep(&inputstring, " \t")) != NULL;)
                        if (**ap != '\0')if (++ap >= &argv[10])break;
                           
                        
                     
                     /.../free(ap[4]);

Since strsep is not allocating any new memory, freeing an element in the middle of the array is equivalent to free a pointer in the middle of inputstring.

This example allocates a BarObj object using the new operator in C++, however, the programmer then deallocates the object using free(), which may lead to unexpected behavior.

Bad

void foo(){
                        BarObj *ptr = new BarObj()
                           /* do some work with ptr here */
                           
                           ...
                           free(ptr);
                     }

Instead, the programmer should have either created the object with one of the malloc family functions, or else deleted the object with the delete operator.

Good

void foo(){
                        BarObj *ptr = new BarObj()
                           /* do some work with ptr here */
                           
                           ...
                           delete ptr;
                     }

In this example, the programmer dynamically allocates a buffer to hold a string and then searches for a specific character. After completing the search, the programmer attempts to release the allocated memory and return SUCCESS or FAILURE to the caller. Note: for simplification, this example uses a hard-coded "Search Me!" string and a constant string length of 20.

Bad

#define SUCCESS (1)#define FAILURE (0)
                     int contains_char(char c){
                        char *str;str = (char*)malloc(20*sizeof(char));strcpy(str, "Search Me!");while( *str != NULL){
                              if( *str == c ){
                                    
                                       
                                       /* matched char, free string and return success */
                                       free(str);return SUCCESS;
                                 }
                                 /* didn't match yet, increment pointer and try next char */
                                 
                                 str = str + 1;
                           }
                           /* we did not match the char in the string, free mem and return failure */
                           
                           free(str);return FAILURE;
                     }

However, if the character is not at the beginning of the string, or if it is not in the string at all, then the pointer will not be at the start of the buffer when the programmer frees it.

Instead of freeing the pointer in the middle of the buffer, the programmer can use an indexing pointer to step through the memory or abstract the memory calculations by using array indexing.

Good

#define SUCCESS (1)#define FAILURE (0)
                     int cointains_char(char c){
                        char *str;int i = 0;str = (char*)malloc(20*sizeof(char));strcpy(str, "Search Me!");while( i < strlen(str) ){
                              if( str[i] == c ){
                                    
                                       
                                       /* matched char, free string and return success */
                                       free(str);return SUCCESS;
                                 }
                                 /* didn't match yet, increment pointer and try next char */
                                 
                                 i = i + 1;
                           }
                           /* we did not match the char in the string, free mem and return failure */
                           
                           free(str);return FAILURE;
                     }

Consider the following code in the context of a parsing application to extract commands out of user data. The intent is to parse each command and add it to a queue of commands to be executed, discarding each malformed entry.

Bad

//hardcode input length for simplicity
                     char* input = (char*) malloc(40*sizeof(char));char *tok;char* sep = " \t";
                     get_user_input( input );
                     
                     /* The following loop will parse and process each token in the input string */
                     
                     tok = strtok( input, sep);while( NULL != tok ){
                        if( isMalformed( tok ) ){
                              
                                 
                                 /* ignore and discard bad data */
                                 free( tok );
                           }else{add_to_command_queue( tok );}tok = strtok( NULL, sep));
                     }

While the above code attempts to free memory associated with bad commands, since the memory was all allocated in one chunk, it must all be freed together.

One way to fix this problem would be to copy the commands into a new memory location before placing them in the queue. Then, after all commands have been processed, the memory can safely be freed.

Good

//hardcode input length for simplicity
                     char* input = (char*) malloc(40*sizeof(char));char *tok, *command;char* sep = " \t";
                     get_user_input( input );
                     
                     /* The following loop will parse and process each token in the input string */
                     
                     tok = strtok( input, sep);while( NULL != tok ){
                        if( !isMalformed( command ) ){
                              
                                 
                                 /* copy and enqueue good data */
                                 command = (char*) malloc( (strlen(tok) + 1) * sizeof(char) );strcpy( command, tok );add_to_command_queue( command );
                           }tok = strtok( NULL, sep));
                     }
                     free( input )

Mitigations & Prevention

Implementation

Only call matching memory management functions. Do not mix and match routines. For example, when you allocate a buffer with malloc(), dispose of the original pointer with free().

Implementation

When programming in C++, consider using smart pointers provided by the boost library to help correctly and consistently manage memory.

Architecture and Design

Use a vetted library or framework that does not allow this weakness to occur or provides constructs that make this weakness easier to avoid. For example, glibc in Linux provides protection against free of invalid pointers.

Architecture and Design

Use a language that provides abstractions for memory allocation and deallocation.

Detection Methods

Fuzzing High — Fuzz testing (fuzzing) is a powerful technique for generating large numbers of diverse inputs - either randomly or algorithmically - and dynamically invoking the code with those inputs. Even with random inputs, it is often capable of generating unexpected results such as crashes, memory corruption,
Automated Dynamic Analysis Moderate — Use tools that are integrated during compilation to insert runtime error-checking mechanisms related to memory safety errors, such as AddressSanitizer (ASan) for C/C++ [REF-1518] or valgrind [REF-480].

Real-World CVE Examples

CVE ID	Description
CVE-2019-11930	function "internally calls 'calloc' and returns a pointer at an index... inside the allocated buffer. This led to freeing invalid memory."

Taxonomy Mappings

Software Fault Patterns: SFP12 — Faulty Memory Release

Frequently Asked Questions

What is CWE-763?

CWE-763 (Release of Invalid Pointer or Reference) is a software weakness identified by MITRE's Common Weakness Enumeration. It is classified as a Base-level weakness. The product attempts to return a memory resource to the system, but it calls the wrong release function or calls the appropriate release function incorrectly.

How can CWE-763 be exploited?

Attackers can exploit CWE-763 (Release of Invalid Pointer or Reference) to modify memory, dos: crash, exit, or restart, execute unauthorized code or commands. This weakness is typically introduced during the Implementation phase of software development.

How do I prevent CWE-763?

Key mitigations include: Only call matching memory management functions. Do not mix and match routines. For example, when you allocate a buffer with malloc(), dispose of the original pointer with free().

What is the severity of CWE-763?

CWE-763 is classified as a Base-level weakness (Medium abstraction). It has been observed in 1 real-world CVEs.

Description

Potential Impact

Integrity, Availability, Confidentiality

Demonstrative Examples

Mitigations & Prevention

Detection Methods

Real-World CVE Examples

Related Weaknesses

CWE-404: Improper Resource Shutdown or Release

Taxonomy Mappings

Frequently Asked Questions