CWE-328: Use of Weak Hash

Description

The product uses an algorithm that produces a digest (output value) that does not meet security expectations for a hash function that allows an adversary to reasonably determine the original input (preimage attack), find another input that can produce the same hash (2nd preimage attack), or find multiple inputs that evaluate to the same hash (birthday attack).

A hash function is defined as an algorithm that maps arbitrarily sized data into a fixed-sized digest (output) such that the following properties hold: Building on this definition, a cryptographic hash function must also ensure that a malicious actor cannot leverage the hash function to have a reasonable chance of success at determining any of the following: What is regarded as "reasonable" varies by context and threat model, but in general, "reasonable" could cover any attack that is more efficient than brute force (i.e., on average, attempting half of all possible combinations). Note that some attacks might be more efficient than brute force but are still not regarded as achievable in the real world. Any algorithm that does not meet the above conditions will generally be considered weak for general use in hashing. In addition to algorithmic weaknesses, a hash function can be made weak by using the hash in a security context that breaks its security guarantees. For example, using a hash function without a salt for storing passwords (that are sufficiently short) could enable an adversary to create a "rainbow table" [REF-637] to recover the password under certain conditions; this attack works against such hash functions as MD5, SHA-1, and SHA-2.

Potential Impact

Demonstrative Examples

unsigned char *check_passwd(char *plaintext) {ctext = simple_digest("sha1",plaintext,strlen(plaintext), ... );
                        //Login if hash matches stored hash
                        if (equal(ctext, secret_password())) {login_user();}}

String plainText = new String(plainTextIn);MessageDigest encer = MessageDigest.getInstance("SHA");encer.update(plainTextIn);byte[] digest = password.digest();
                     //Login if hash matches stored hash
                     if (equal(digest,secret_password())) {login_user();}

...
               logic [31:0] data_d, data_q
               logic [512-1:0] pass_data;
               ...
                  
                  Write: begin
                     
                     ...
                        
                        if (pass_mode) begin
                           
                           pass_data = { {60{8'h00}}, data_d};
                           state_d = PassChk;
                           pass_mode = 1'b0;
                           
                        ...
                        
                     
                  end
                  
               ...

...
               logic [512-1:0] data_d, data_q
               logic [512-1:0] pass_data;
               ...
                  
                  Write: begin
                     
                     ...
                        
                        if (pass_mode) begin
                           
                           pass_data = data_d;
                           state_d = PassChk;
                           pass_mode = 1'b0;
                           
                        ...
                        
                     
                  end
                  
               ...

Mitigations & Prevention

Detection Methods

• Automated Static Analysis High — Automated static analysis, commonly referred to as Static Application Security Testing (SAST), can find some instances of this weakness by analyzing source code (or binary/compiled code) without having to execute it. Typically, this is done by building a model of data flow and control flow, then sea

Real-World CVE Examples

Related Weaknesses

Taxonomy Mappings

• PLOVER: — Reversible One-Way Hash